feat: add support for UUID and PG_UUID types across Spanner migration utilities. by pratickchokhani · Pull Request #3905 · GoogleCloudPlatform/DataflowTemplates

pratickchokhani · 2026-06-10T10:58:44Z

No description provided.

codecov · 2026-06-10T11:30:30Z

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.69%. Comparing base (65d422a) to head (5264417).
⚠️ Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
.../v2/spanner/migrations/avro/AvroToValueMapper.java	66.66%	2 Missing ⚠️
...eport/v2/templates/transforms/AssignShardIdFn.java	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3905      +/-   ##
============================================
+ Coverage     55.59%   55.69%   +0.10%     
- Complexity     7052     7196     +144     
============================================
  Files          1103     1117      +14     
  Lines         67681    68340     +659     
  Branches       7603     7702      +99     
============================================
+ Hits          37625    38063     +438     
- Misses        27636    27810     +174     
- Partials       2420     2467      +47

Components	Coverage Δ
spanner-templates	`87.80% <84.00%> (-0.69%)`	⬇️
spanner-import-export	`68.69% <ø> (-0.02%)`	⬇️
spanner-live-forward-migration	`89.81% <90.47%> (-0.44%)`	⬇️
spanner-live-reverse-replication	`83.65% <84.00%> (-0.79%)`	⬇️
spanner-bulk-migration	`92.57% <90.47%> (-0.06%)`	⬇️
gcs-spanner-dv	`88.85% <90.47%> (-0.06%)`	⬇️

Files with missing lines	Coverage Δ
...m/google/cloud/teleport/v2/spanner/ddl/Column.java	`91.52% <100.00%> (+0.40%)`	⬆️
...er/migrations/avro/GenericRecordTypeConvertor.java	`96.27% <100.00%> (ø)`
...ations/convertors/ChangeEventSpannerConvertor.java	`85.24% <ø> (ø)`
...igrations/convertors/ChangeEventTypeConvertor.java	`88.05% <ø> (ø)`
...2/spanner/migrations/spanner/SpannerReadUtils.java	`88.15% <ø> (ø)`
...om/google/cloud/teleport/v2/spanner/type/Type.java	`99.46% <100.00%> (+0.01%)`	⬆️
.../v2/spanner/migrations/avro/AvroToValueMapper.java	`93.53% <66.66%> (-0.72%)`	⬇️
...eport/v2/templates/transforms/AssignShardIdFn.java	`83.43% <50.00%> (+0.21%)`	⬆️

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… utilities

…eMapper

gemini-code-assist · 2026-06-19T08:07:16Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces first-class support for UUID and PG_UUID data types within the Spanner migration framework. By updating the core type system, mapping logic, and conversion utilities, the changes ensure that UUID fields are correctly identified, mapped, and processed during data migration tasks. These updates improve the robustness of the migration pipeline when dealing with UUID-based schemas.

Highlights

UUID Type Support: Added comprehensive support for UUID and PG_UUID types across Spanner migration utilities, including type definitions, mapping logic, and DDL handling.
Migration Utilities Updates: Updated Avro-to-Spanner mappers, change event converters, and Spanner read utilities to correctly handle UUID data types.
Testing and Validation: Expanded integration tests and schema definitions to validate UUID handling across various migration scenarios, including primary key support and data type conversion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for the UUID and PG_UUID data types across several Spanner-related templates and common utilities, including schema parsing, Avro mapping, and change event conversion. A critical compilation issue was identified in AssignShardIdFn.java, where value.getUuid() is called on a Spanner Value object. Since the Spanner Java SDK does not have a getUuid() method, this must be updated to use value.getString() instead.

aasthabharill

Please verify that gcs-spanner-dv template also incorporates support for Spanner UUID type. I suspect the hashing logic might need some addition

Can you please also add details of any end to end tests you ran in the description

aasthabharill

LGTM

pull-request-size Bot added the size/M label Jun 10, 2026

pratickchokhani added the addition New feature or request label Jun 10, 2026

pratickchokhani force-pushed the uuid-target-side branch from 2481637 to 6b26c9e Compare June 10, 2026 11:06

pull-request-size Bot added size/L and removed size/M labels Jun 10, 2026

pratickchokhani force-pushed the uuid-target-side branch from 6b26c9e to f4ad6ae Compare June 10, 2026 11:17

pratickchokhani force-pushed the uuid-target-side branch 12 times, most recently from b2bd219 to 4566208 Compare June 17, 2026 08:58

feat: add support for UUID and PG_UUID types across Spanner migration…

e6e9753

… utilities

pratickchokhani force-pushed the uuid-target-side branch 4 times, most recently from 7924f38 to 368d1c1 Compare June 18, 2026 10:47

feat: add UUID support for GSQL and PG dialect mappings in AvroToValu…

6039a06

…eMapper

pratickchokhani force-pushed the uuid-target-side branch from 368d1c1 to 6039a06 Compare June 19, 2026 08:02

pratickchokhani marked this pull request as ready for review June 19, 2026 08:07

pratickchokhani requested a review from a team as a code owner June 19, 2026 08:07

pratickchokhani requested review from shreyakhajanchi and sm745052 June 19, 2026 08:07

pratickchokhani requested review from aasthabharill and removed request for shreyakhajanchi June 19, 2026 08:07

gemini-code-assist Bot reviewed Jun 19, 2026

View reviewed changes

Comment thread ...ourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/AssignShardIdFn.java

pratickchokhani requested a review from bharadwaj-aditya June 24, 2026 12:06

aasthabharill requested changes Jun 24, 2026

View reviewed changes

aasthabharill reviewed Jun 24, 2026

View reviewed changes

Comment thread ...ourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/AssignShardIdFn.java

aasthabharill reviewed Jun 24, 2026

View reviewed changes

Comment thread ...rc/test/java/com/google/cloud/teleport/v2/spanner/migrations/avro/AvroToValueMapperTest.java

aasthabharill reviewed Jun 24, 2026

View reviewed changes

Comment thread ...on/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/avro/AvroToValueMapper.java

aasthabharill reviewed Jun 24, 2026

View reviewed changes

Comment thread ...ourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/AssignShardIdFn.java

bharadwaj-aditya reviewed Jun 25, 2026

View reviewed changes

Comment thread v2/datastream-to-spanner/src/test/resources/MySQLDataTypesIT/pg-dialect-spanner-schema.sql

Comment thread v2/sourcedb-to-spanner/src/test/resources/DataTypesIT/postgresql-pg-dialect-spanner-schema.sql Outdated

pull-request-size Bot added size/XL and removed size/L labels Jul 1, 2026

pratickchokhani force-pushed the uuid-target-side branch 4 times, most recently from 086a9e2 to 4fd1a5f Compare July 2, 2026 10:33

UUID PK types

5264417

pratickchokhani force-pushed the uuid-target-side branch from 4fd1a5f to 5264417 Compare July 2, 2026 10:49

pratickchokhani requested a review from aasthabharill July 2, 2026 10:53

aasthabharill approved these changes Jul 2, 2026

View reviewed changes

pratickchokhani merged commit 925c463 into GoogleCloudPlatform:main Jul 2, 2026
34 checks passed

Navigation Menu

Uh oh!

feat: add support for UUID and PG_UUID types across Spanner migration utilities. - #3905

feat: add support for UUID and PG_UUID types across Spanner migration utilities.#3905
pratickchokhani merged 3 commits into
GoogleCloudPlatform:mainfrom
pratickchokhani:uuid-target-side

pratickchokhani commented Jun 10, 2026

Uh oh!

codecov Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jun 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

aasthabharill left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aasthabharill left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pratickchokhani commented Jun 10, 2026

Uh oh!

codecov Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist Bot commented Jun 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

aasthabharill left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aasthabharill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jun 10, 2026 •

edited

Loading

aasthabharill left a comment •

edited

Loading